Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt the new room list service syncIndicatorListener #1652

Merged
merged 1 commit into from Sep 7, 2023

Conversation

stefanceriu
Copy link
Contributor

  • expose sync service loading state through a client proxy current value publisher and use it accordingly
  • a current value publisher because the UI might not be instantiated by the time it finishes loading

@stefanceriu stefanceriu requested a review from a team as a code owner September 7, 2023 09:44
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team September 7, 2023 09:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 92965f0

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (62b6cd5) 58.54% compared to head (92965f0) 58.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1652      +/-   ##
===========================================
- Coverage    58.54%   58.53%   -0.01%     
===========================================
  Files          413      413              
  Lines        28230    28242      +12     
  Branches     14066    14073       +7     
===========================================
+ Hits         16527    16532       +5     
- Misses       11250    11255       +5     
- Partials       453      455       +2     
Flag Coverage Δ
unittests 22.85% <0.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift 53.96% <0.00%> (-2.26%) ⬇️
ElementX/Sources/Services/Client/ClientProxy.swift 45.27% <0.00%> (-3.08%) ⬇️
.../Sources/Services/Client/ClientProxyProtocol.swift 0.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit fad608c into develop Sep 7, 2023
10 checks passed
@stefanceriu stefanceriu deleted the stefan/rustSideClientLoadingStates branch September 7, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants