Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rich text editor "expanded mode" #1656

Merged
merged 17 commits into from Sep 11, 2023
Merged

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Sep 8, 2023

This PR adds the "expanded" composer mode when the user uses the RTE editor

Fix #1641

Result

demo2.MP4

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 689fadd

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 4.54% and project coverage change: -0.20% ⚠️

Comparison is base (89c4786) 58.81% compared to head (bd65ec0) 58.61%.

❗ Current head bd65ec0 differs from pull request most recent head 689fadd. Consider uploading reports for the commit 689fadd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1656      +/-   ##
===========================================
- Coverage    58.81%   58.61%   -0.20%     
===========================================
  Files          413      414       +1     
  Lines        28336    28405      +69     
  Branches     14099    14127      +28     
===========================================
- Hits         16665    16650      -15     
- Misses       11210    11293      +83     
- Partials       461      462       +1     
Flag Coverage Δ
unittests 22.63% <4.54%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
ElementX/Sources/Other/Extensions/Comparable.swift 0.00% <0.00%> (ø)
...ens/ComposerToolbar/ComposerToolbarViewModel.swift 65.33% <ø> (-0.16%) ⬇️
...Screens/ComposerToolbar/View/ComposerToolbar.swift 54.33% <0.00%> (-3.17%) ⬇️
...Screens/ComposerToolbar/View/MessageComposer.swift 25.37% <0.00%> (-15.88%) ⬇️
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift 56.39% <0.00%> (-8.57%) ⬇️
...creens/ComposerToolbar/ComposerToolbarModels.swift 38.02% <100.00%> (+0.43%) ⬆️
...ces/Screens/RoomScreen/RoomScreenCoordinator.swift 86.48% <100.00%> (+0.37%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfogrillo alfogrillo marked this pull request as ready for review September 8, 2023 11:10
@alfogrillo alfogrillo requested a review from a team as a code owner September 8, 2023 11:10
@alfogrillo alfogrillo requested review from Velin92 and removed request for a team September 8, 2023 11:10
Copy link
Contributor

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo enabled auto-merge (squash) September 11, 2023 07:46
@alfogrillo alfogrillo merged commit bd4ee92 into develop Sep 11, 2023
6 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/rte-fullscreen branch September 11, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rich Text Editor fullscreen mode
2 participants