Pill View

[Velin92]

NOTES:

• Can be activated with a FF in Dev options
• The designs are improvised and not final
• There is also a loading state
• Sadly the snapshot tests do not seems to support text attachments, so it appears as empty (even if the size is actually correct! so I wonder if is a window/overlay limitation of the snapshot)
• However we have the pill view itself being snapshot tested
• They are tappable but they still behave as links did before, so they the tap is still unhandled

The designs are not final

[github-actions]

	Warnings
⚠️	This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 602cc5b

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dSC9CG

[pixlwave]

Love that we have pills working in the app now 👏

[codecov]

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (8d4c5e2) 71.43% compared to head (7665546) 71.48%.

❗ Current head 7665546 differs from pull request most recent head 602cc5b. Consider uploading reports for the commit 602cc5b to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1797      +/-   ##
===========================================
+ Coverage    71.43%   71.48%   +0.05%     
===========================================
  Files          434      439       +5     
  Lines        29659    29919     +260     
  Branches     14588    14693     +105     
===========================================
+ Hits         21187    21388     +201     
- Misses        7943     7994      +51     
- Partials       529      537       +8     

Flag	Coverage Δ
unittests	54.91% <79.46%> (+0.15%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
ElementX/Sources/Application/AppCoordinator.swift	54.89% <ø> (-0.07%)	⬇️
ElementX/Sources/Application/AppSettings.swift	96.55% <ø> (ø)
...Sources/FlowCoordinators/RoomFlowCoordinator.swift	54.88% <100.00%> (+0.06%)	⬆️
...es/Other/HTMLParsing/AttributedStringBuilder.swift	89.82% <100.00%> (+0.53%)	⬆️
...rces/Other/SwiftUI/Animation/ShimmerModifier.swift	100.00% <ø> (ø)
...X/Sources/Screens/HomeScreen/View/HomeScreen.swift	80.56% <100.00%> (ø)
...ens/HomeScreen/View/HomeScreenEmptyStateView.swift	96.66% <100.00%> (ø)
...s/Screens/HomeScreen/View/HomeScreenRoomCell.swift	98.27% <100.00%> (+<0.01%)	⬆️
...s/RoomScreen/View/Timeline/FormattedBodyText.swift	99.46% <100.00%> (+<0.01%)	⬆️
...en/View/Timeline/TimelineTableViewController.swift	82.98% <100.00%> (ø)
... and 15 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefanceriu]

This is an amazing start, well done! 👏
Left some comments inline, most of them minor.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[pixlwave]

Love it, this all looks great to me 👏

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication