Add "end poll" confirmation dialog #1799

alfogrillo · 2023-09-26T09:25:55Z

This PR adds a confirmation dialog when ending a poll directly using the "creator view" in the timeline.

Result

github-actions · 2023-09-26T09:27:07Z

	Warnings
⚠️	Please add a changelog.
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️	You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 4fb34f5

codecov · 2023-09-26T09:46:07Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a05c3e3) 71.41% compared to head (1b3b860) 71.27%.
Report is 2 commits behind head on develop.

❗ Current head 1b3b860 differs from pull request most recent head 4fb34f5. Consider uploading reports for the commit 4fb34f5 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1799      +/-   ##
===========================================
- Coverage    71.41%   71.27%   -0.15%     
===========================================
  Files          434      434              
  Lines        29563    29567       +4     
  Branches     14569    14569              
===========================================
- Hits         21113    21074      -39     
- Misses        7926     7968      +42     
- Partials       524      525       +1

Flag	Coverage Δ
unittests	`54.54% <14.28%> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
.../Sources/Screens/RoomScreen/RoomScreenModels.swift	`72.97% <ø> (ø)`
...X/Sources/Screens/RoomScreen/View/RoomScreen.swift	`73.68% <100.00%> (+0.19%)`	⬆️
...s/CreatePollScreen/CreatePollScreenViewModel.swift	`48.71% <0.00%> (ø)`
...urces/Screens/RoomScreen/RoomScreenViewModel.swift	`56.00% <0.00%> (-0.43%)`	⬇️