Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Poll start" event push notification #1819

Merged
merged 2 commits into from Sep 28, 2023

Conversation

alfogrillo
Copy link
Contributor

@alfogrillo alfogrillo commented Sep 28, 2023

This PR handles push notifications for "poll start" events.
Other work will follow to handle the related push rules on EX.

Result
Simulator Screenshot - iPhone 14 - 2023-09-28 at 10 28 14

@alfogrillo alfogrillo self-assigned this Sep 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 28, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against bdc74a4

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (7bde419) 71.50% compared to head (bdc74a4) 71.41%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1819      +/-   ##
===========================================
- Coverage    71.50%   71.41%   -0.10%     
===========================================
  Files          438      438              
  Lines        29889    29889              
  Branches     14683    14683              
===========================================
- Hits         21373    21344      -29     
- Misses        7978     8012      +34     
+ Partials       538      533       -5     
Flag Coverage Δ
unittests 54.83% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alfogrillo alfogrillo marked this pull request as ready for review September 28, 2023 08:39
@alfogrillo alfogrillo requested a review from a team as a code owner September 28, 2023 08:39
@alfogrillo alfogrillo requested review from stefanceriu and removed request for a team September 28, 2023 08:39
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

NSE/Sources/NotificationContentBuilder.swift Show resolved Hide resolved
@alfogrillo alfogrillo merged commit ee0539f into develop Sep 28, 2023
10 checks passed
@alfogrillo alfogrillo deleted the alfogrillo/polls-notifications branch September 28, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants