@room pill #1834

Velin92 · 2023-09-29T12:03:15Z

This also introduces the red color for when the mentions is of self, and adds more testing.

github-actions · 2023-09-29T12:04:24Z

	Warnings
⚠️	Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against e73a8be

codecov · 2023-09-29T12:34:48Z

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (1e842fd) 71.42% compared to head (670882b) 71.31%.

❗ Current head 670882b differs from pull request most recent head e73a8be. Consider uploading reports for the commit e73a8be to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1834      +/-   ##
===========================================
- Coverage    71.42%   71.31%   -0.11%     
===========================================
  Files          438      438              
  Lines        29931    29962      +31     
  Branches     14694    14694              
===========================================
- Hits         21377    21368       -9     
- Misses        8017     8054      +37     
- Partials       537      540       +3

Flag	Coverage Δ
unittests	`54.80% <81.25%> (-0.09%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...ces/Other/HTMLParsing/ElementXAttributeScope.swift	`0.00% <ø> (ø)`
ElementX/Sources/Other/MatrixEntityRegex.swift	`96.55% <100.00%> (+0.63%)`	⬆️
...X/Sources/Other/Pills/PillTextAttachmentData.swift	`87.50% <ø> (ø)`
.../Sources/Screens/RoomScreen/RoomScreenModels.swift	`72.97% <ø> (ø)`
...urces/Screens/RoomScreen/RoomScreenViewModel.swift	`56.19% <100.00%> (+0.05%)`	⬆️
...es/Other/HTMLParsing/AttributedStringBuilder.swift	`90.49% <95.12%> (+0.49%)`	⬆️
...urces/Other/Pills/PillAttachmentViewProvider.swift	`55.26% <50.00%> (ø)`
ElementX/Sources/Other/Pills/PillContext.swift	`87.23% <83.33%> (-2.32%)`	⬇️
ElementX/Sources/Other/Pills/PillView.swift	`79.41% <62.50%> (-6.31%)`	⬇️
ElementX/Sources/Other/Pills/MentionBuilder.swift	`68.75% <65.21%> (-3.25%)`	⬇️