New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement emotes (/me) #1841
implement emotes (/me) #1841
Conversation
Generated by 🚫 Danger Swift against 984e9a5 |
How do I make the tests run against the right sdk branch name? (EW would at least automatically try to build against the branch of the same name in the SDK...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments inline for a couple of small tweaks that need to happen. Otherwise looks sensible to me.
@Velin92 you were going to look into user suggestions this week. They should probably be based on CompletionSuggestion
from the old codebase which also supports slash commands so please take this PR under your wing.
There is nothing like that atm. We agreed to look into building the sdk on the CI after the next release and this can very well be a part of that work. |
We will also need to improve the infra. GH action runners are slow to build the SDK bindings. They take 4h to build them for Android. This would be way too long to validate a PR on EAX or EIX. |
ptal @stefanceriu |
requires matthew/emotes branch of matrix-rust-sdk
095e5b5
to
984e9a5
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1841 +/- ##
===========================================
- Coverage 71.49% 71.31% -0.19%
===========================================
Files 442 442
Lines 30058 30083 +25
Branches 14738 14748 +10
===========================================
- Hits 21490 21453 -37
- Misses 8031 8093 +62
Partials 537 537
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
requires matrix-org/matrix-rust-sdk#2648
closes #1107
Arguably this could be handled by a slash-command engine in matrix-sdk-ui, but given it's not clear EX is going to even have slash commands (given whatsapp & imessage & signal etc don't), I'm adding it as a quick & dirty easter egg in the application layer. Given the logic is so simple, I'm not convinced it's worth the complexity of shoving it into the SDK at this point.
Handles:
/me
/me
Pull Request Checklist