Implement AppLockScreen as per the designs. #1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/app-lock-pin-screen
branch
from
d95971a
to
55cba62
Compare
pixlwave
force-pushed
the
doug/app-lock-pin-screen
branch
from
55cba62
to
b42a403
Compare
Generated by 🚫 Danger Swift against 43a2a5f |
|
The nudge is so cute! |
amshakal
approved these changes
Oct 19, 2023
stefanceriu
approved these changes
Oct 20, 2023
ElementX/Sources/Screens/AppLock/AppLockScreen/AppLockScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/AppLock/AppLockScreen/AppLockScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/AppLock/AppLockScreen/View/AppLockScreenPINKeypad.swift
Show resolved
Hide resolved
Fix a bug in the unlock flow and add VoiceOver hints.
pixlwave
force-pushed
the
doug/app-lock-pin-screen
branch
from
b42a403
to
43a2a5f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the implementation of AppLockScreen as per the designs. Landscape iPhone does work but isn't ideal. Not handling it in this PR as its very much an edge case.
Simulator.Screen.Recording.-.iPhone.14.-.2023-10-19.at.14.08.43.mp4