New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace detached tasks with Task.dispatch(on:)
#201
Conversation
Generated by 🚫 Danger Swift against 69e0b9e |
25a102e
to
7463dcc
Compare
DispatchQueue.awaitable
option.
7463dcc
to
118b864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny question inline, otherwise LGTM!
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RX2Ynj |
Codecov ReportBase: 11.91% // Head: 11.97% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #201 +/- ##
===========================================
+ Coverage 11.91% 11.97% +0.06%
===========================================
Files 203 208 +5
Lines 13565 14146 +581
Branches 6616 6844 +228
===========================================
+ Hits 1616 1694 +78
- Misses 11909 12412 +503
Partials 40 40
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
DispatchQueue.awaitable
option.Task.dispatch(on:)
.
Task.dispatch(on:)
.Task.dispatch(on:)
This should stop us from ever overwhelming the workers with too many detached tasks that don't suspend.
All
Task.detached
that didn't have anawait
and so were presumably blocking, have been replaced with continuations that dispatch onto the specified queue. A future tweak could be to make separate queues or to provide a QoS to the global queue.