Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blockquote bubbles to fill the message bubble #527

Merged
merged 4 commits into from Feb 6, 2023
Merged

Conversation

pixlwave
Copy link
Contributor

@pixlwave pixlwave commented Feb 6, 2023

Use a custom layout to prevent them from unnecessarily widening the bubble.

I hope the code is well enough documented to describe how this is done, please add comments where unclear and I'll add more documentation.

IMG_DBBE4B12F03B-1

Use a custom layout to prevent them from unnecessarily widening the bubble.
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against be83a58

@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Base: 40.78% // Head: 40.54% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (0e1ce2a) compared to base (027de70).
Patch coverage: 24.80% of modified lines in pull request are covered.

❗ Current head 0e1ce2a differs from pull request most recent head be83a58. Consider uploading reports for the commit be83a58 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #527      +/-   ##
===========================================
- Coverage    40.78%   40.54%   -0.24%     
===========================================
  Files          290      290              
  Lines        16749    16847      +98     
  Branches     11166    11200      +34     
===========================================
  Hits          6831     6831              
- Misses        9601     9700      +99     
+ Partials       317      316       -1     
Flag Coverage Δ
unittests 20.77% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Timeline/PaginationIndicatorRoomTimelineView.swift 0.00% <0.00%> (ø)
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 16.31% <25.00%> (-16.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments inline but also talked about this offline, looks good to me 👍

@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave enabled auto-merge (squash) February 6, 2023 13:25
@pixlwave pixlwave merged commit 2734a18 into develop Feb 6, 2023
@pixlwave pixlwave deleted the doug/design branch February 6, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants