Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afterSyncCompleted stage is run on any room with joined member, even if we don't have an outbound session for it #245

Closed
bwindels opened this issue Feb 24, 2021 · 2 comments
Closed

afterSyncCompleted stage is run on any room with joined member, even if we don't have an outbound session for it #245

bwindels opened this issue Feb 24, 2021 · 2 comments
Labels
maintenance performance

Comments

@bwindels
Copy link
Contributor

bwindels commented Feb 24, 2021 •
edited
Loading

Room.needsAfterSyncCompleted only checks if there was a join in the room response, but not if the earlier call to RoomEncryption._addShareRoomKeyOperationForNewMembers actually added a key share operation (which it would only do if we have an outbound megolm session for the room). This is not problematic, but a minor inefficiency and makes the logs a bit verbose.
@bwindels bwindels added this to Backlog (highest prio at top) in Roadmap Feb 25, 2021
@bwindels
Copy link
Contributor Author

bwindels commented Mar 1, 2021

Possibly makes sense to look at it together with #192

@bwindels bwindels moved this from Backlog (highest prio at top) to In progress in Roadmap Mar 2, 2021
bwindels added a commit that referenced this issue Mar 2, 2021
@bwindels
attempt at fixing #245
7f17f5c
bwindels added a commit that referenced this issue Mar 3, 2021
@bwindels
attempt at fixing #245
56db210
@bwindels bwindels moved this from In progress to Backlog (highest prio at top) in Roadmap Mar 3, 2021
@bwindels
Copy link
Contributor Author

bwindels commented Mar 3, 2021

This was fixed in above linked commit

@bwindels bwindels closed this as completed Mar 3, 2021
sandhose pushed a commit to sandhose/hydrogen-web that referenced this issue May 20, 2021
@bwindels @sandhose
attempt at fixing element-hq#245
69a154f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bwindels