Room list ordering isn't always stable

[bwindels]

Sometimes when you close a room/go to another one that was unread, the room you left goes all the way to the bottom or somewhere close.

One reason could be that the properties of the room have changed without causing a rerendering somehow, so what you see isn't what is being sorted anymore. Unsure how that could happen though.

Another reason could be that lastMessageTimestamp ends up something else than null or a number (e.g. undefined).

[bwindels]

Interesting, I was able to reproduce the problem on 0.0.33 with logging captured and the room that become unread didn't show up in the sorting log after going to another one... bug in sorter or observable collections?

[bwindels]

I think the this.emitChange("isOpen") in RoomTileViewModel.close is somehow not triggering a resort, so the list is not in sorting order anymore, messing things open?

I stepped through that code path though and it did trigger a resort...

[bwindels]

I think the this.emitChange("isOpen") in RoomTileViewModel.close is somehow not triggering a resort,

It's not this, the resort logs appear above "close timeline for room x"

[bwindels]

The problem seems to be indeed a timestamp being undefined. The above PR fixes that but we'll need further testing to see if this actually solves it. Also, we need to figure out why the timestamp is undefined. Did origin_server_ts end up on unsigned perhaps?

[bwindels]

This seems fixed now