Implemented /join #809
Merged
Implemented /join #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al commands uses, and some others commands like /shrug .)
Closed
…id the synchronisations waits that can sometimes disable to enter the room (message "You're not into this room" or simply "You're not in this room yet. *Join the room*")
bwindels
reviewed
Jul 25, 2022
…q#809) - Correction des erreurs d'indentations.
into RoomViewModel._processCommands
If the /join command success, an error was thrown, because of a copy-pasted command not well integrated The button of the error on "theme.css" contains now an unicode cross. The :after/:before cross was disformed when opening the room informations.
- renamed executeJoinCommand as joinRoom; - separated the joinRoom process and the parse and result process
|
I cannot send any message with this implement, it doesn't throw any error, I can see the I often have this error : I absolutely don't know why this probleme occurs, I have read all my code again and if the first conditions are not entered by a simple message, I don't understand why the message isn't sent. |
- fixed a pretty syntax miss (a !== b); - fixed a type error : replaced "msgtype" by "type" when instantied the "messinfo" variable; - some indentation fixes
MidhunSureshR
approved these changes
Jul 28, 2022
- joined the processJoinRoom and joinRoom methods; - fixed some precisions miss; - removed some useless code; - change the error message height from absolute (40px) to relative (auto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the /join command.
Change that have been added
switchsyntax to improve the commands manager.Should fix this issue (#792).