Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the linting errors #11

Merged
merged 6 commits into from
Dec 10, 2019
Merged

Fix the linting errors #11

merged 6 commits into from
Dec 10, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 10, 2019

Based on #10

@dbkr
Pack the webapp into an asar
672b846
@dbkr
Oops, don't remove the aftersign script
8322676
@dbkr
Search for the webapp resources on startup
8d35297 
and error if we can't find them.
@dbkr
Remove unnecessary logging
680caed
@dbkr
Electron API updates
a13c0e0 
A couple of changes to properties rather than functions and the
register*Protocol functionsd are now synchronous and so don't need
a completion callback.
@dbkr
Fix the linting errors
14a919c
@dbkr dbkr requested a review from a team December 10, 2019 18:10
turt2live
turt2live approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels a bit extreme in some places, but that's an argument for another day.

@dbkr dbkr merged commit 754634e into master Dec 10, 2019
@t3chguy t3chguy deleted the dbkr/lint branch May 3, 2022 09:56
@rda0 rda0 mentioned this pull request Aug 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbkr @turt2live