Better Docker Support #17
Conversation
So we can say we replace the riot-web package
So you can run yarn install in the docker container
package.json
Outdated
| @@ -18,6 +18,9 @@ | |||
| "start": "electron .", | |||
| "lint": "eslint src/", | |||
| "build": "yarn run setversion && electron-builder", | |||
| "indocker": "scripts/indocker.sh", | |||
There was a problem hiding this comment.
can we call it something else or add punctuation? I'm probably the only one with the problem, but every time I've read this it's either "indicator" or something NSFW. "in-docker" would be fine imo.
There was a problem hiding this comment.
yeah, I;d be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
yeah, I'd be up for changing it - just used the value we'd been using previously
There was a problem hiding this comment.
yeah, I'd be up for changing it - just used the value we'd been using previously
So you can run yarn install in the docker container
Based on #14