Build the deb into a repo #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Dec 13, 2019
scripts/mkrepo.sh
Outdated
| set -x | ||
| set -e | ||
|
|
||
| ver=`node -e "require('fs'); console.log(JSON.parse(fs.readFileSync('package.json')).version)"` |
There was a problem hiding this comment.
🤢🤮
NodeJS is great, but ohgod. Can we use something like jq instead? Stack Overflow says it is possible: https://stackoverflow.com/questions/53967693/how-to-run-jq-from-gitbash-in-windows
There was a problem hiding this comment.
maybe, but it's another thing everyone has to install, and we know we have node... (This is building the deb repo so this one we don't need to work in windows).
There was a problem hiding this comment.
it doesn't sound too painful to require another dependency (it's the same apt-get?)
and also remove env.sh which didn;t want to be here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With distributions configured by the config dir because that determines the signing key
Fixes element-hq/element-web#11649
Based on #17