Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass through the env var we actually use to docker #33

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Pass through the env var we actually use to docker #33

merged 4 commits into from
Feb 28, 2020

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Feb 27, 2020

No description provided.

@dbkr dbkr requested a review from a team February 27, 2020 16:57
turt2live
turt2live approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need to worry about other buildkite vars like the branch name, etc?

@dbkr
Copy link
Member Author

dbkr commented Feb 28, 2020

atm we don't use any of them, so probably better to specifically pass through the ones we want when we use them.

@dbkr dbkr merged commit c4f6ff4 into master Feb 28, 2020
@t3chguy t3chguy deleted the dbkr/docker-env branch May 3, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dbkr @turt2live