Package webapp into an asar archive #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the fetch script package the webapp up into an asar archive. Means we can have all the random riot resources in one archive file on the user's machine which generally keeps things tidier and might save some space. Also means we don't have to deal with making electron-builder follow symlinks...
Also some chunky but not actually terribly significant changes to the app code to search for the webapp resources before startup (this is async so we need to wait for this to happen before continuing with startup). Previously, by pure chance, this was '../../' whether we were running from a source checkout or from a built app because our main source file was at
electron_app/src/. It's now just insrc/so is only one directory level above when running from a source checkout. We now try both locations (along with justwebappas we did before so you can symlink in for dev).As a bonus, we now exit when we can't find the resources rather than display an app with a blank, white screen which was a common pitfall before. This also means we don't need to run the check script when just running the electron app since the app itself will bail sensibly.
Also Remove the call to
install:electronbecause we removed that script in #8.