Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings/Bind: Ask the user to validate the email again if they have … #2749

Merged
merged 1 commit into from Oct 4, 2019

Conversation

manuroe
Copy link
Member

@manuroe manuroe commented Oct 4, 2019

…not validated it yet

instead of displaying an error dialog.
This bug happened only with the new HS add and bind APIs (MSC2290) flow because new IS API returns only M_UNKNOWN.

Before:
Simulator Screen Shot - iPhone 8 - 2019-10-04 at 14 12 29

After:
Simulator Screen Shot - iPhone 8 - 2019-10-04 at 13 41 45

…not validated it yet

instead of displaying an error dialog.
This bug happened only with the new HS add and bind APIs (MSC2290) flow because new IS API returns only `M_UNKNOWN`.
@manuroe manuroe merged commit 64e6831 into develop Oct 4, 2019
@manuroe manuroe deleted the fix_bind_continue branch October 4, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants