Skip to content

Commit

Permalink
Merge pull request #9278 from jryans/storage-edge-cases
Browse files Browse the repository at this point in the history
Convert away from `Promise.defer`
  • Loading branch information
jryans committed Mar 26, 2019
2 parents 7ac117f + f321aba commit 2e24b0c
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions test/app-tests/loading.js
Expand Up @@ -123,9 +123,6 @@ describe('loading:', function() {
toString: function() { return this.search + this.hash; },
};

const tokenLoginCompleteDefer = Promise.defer();
tokenLoginCompletePromise = tokenLoginCompleteDefer.promise;

function onNewScreen(screen) {
console.log(Date.now() + " newscreen "+screen);
const hash = '#/' + screen;
Expand Down Expand Up @@ -157,18 +154,21 @@ describe('loading:', function() {
PlatformPeg.set(new WebPlatform());

const params = parseQs(windowLocation);
matrixChat = ReactDOM.render(
<MatrixChat
onNewScreen={onNewScreen}
config={config}
realQueryParams={params}
startingFragmentQueryParams={fragParts.params}
enableGuest={true}
onTokenLoginCompleted={() => tokenLoginCompleteDefer.resolve()}
initialScreenAfterLogin={getScreenFromLocation(windowLocation)}
makeRegistrationUrl={() => {throw new Error('Not implemented');}}
/>, parentDiv,
);

tokenLoginCompletePromise = new Promise(resolve => {
matrixChat = ReactDOM.render(
<MatrixChat
onNewScreen={onNewScreen}
config={config}
realQueryParams={params}
startingFragmentQueryParams={fragParts.params}
enableGuest={true}
onTokenLoginCompleted={resolve}
initialScreenAfterLogin={getScreenFromLocation(windowLocation)}
makeRegistrationUrl={() => {throw new Error('Not implemented');}}
/>, parentDiv,
);
});
}

// set an expectation that we will get a call to /sync, then flush
Expand Down

0 comments on commit 2e24b0c

Please sign in to comment.