Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Soft logout: Support SSO for rehydrating the session #10238

Closed
turt2live opened this issue Jul 2, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3197
Closed

Soft logout: Support SSO for rehydrating the session #10238

turt2live opened this issue Jul 2, 2019 · 2 comments · Fixed by matrix-org/matrix-react-sdk#3197
Assignees
@turt2live
Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement

Comments

@turt2live
Copy link
Member

The primary use case for this is SSO login renewal, so we should make sure it works with that. Other login flows (password, email, etc) should also work.
@turt2live turt2live added feature P1 A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 labels Jul 2, 2019
@turt2live turt2live mentioned this issue Jul 2, 2019
Closed
@turt2live turt2live added phase:1 and removed phase:1 labels Jul 4, 2019
@turt2live turt2live changed the title Soft logout: Make sure it works with SSO and other login flows Soft logout: Make sure it works with SSO Jul 4, 2019
@turt2live
Copy link
Member Author

turt2live commented Jul 4, 2019 •
edited

Just SSO, not other flows at the moment - password login is tested elsewhere

@turt2live turt2live changed the title Soft logout: Make sure it works with SSO Soft logout: Support SSO for rehydrating the session Jul 4, 2019
@turt2live turt2live mentioned this issue Jul 4, 2019
Closed
@turt2live turt2live self-assigned this Jul 5, 2019
@turt2live turt2live added this to In Progress in Web App Team via automation Jul 5, 2019
@turt2live
Copy link
Member Author

The demo setup for testing returns password login on the homeserver, but SSO on the 'gateway' (what even is this thing called?). In order for us to reauth the user, we'll need the homeserver to expose SSO so we can reauth against it directly and rehydrate our local session.

SSO login would have to result in using the same homeserver otherwise the session is useless.

Blocked on the demo environment doing the right thing.

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Jul 10, 2019
@turt2live
Support SSO for rehydrating a soft-logged-out session.
1eb60ef 
Fixes element-hq/element-web#10238
@turt2live turt2live mentioned this issue Jul 10, 2019
Merged
@turt2live turt2live moved this from In Progress to In Review in Web App Team Jul 10, 2019
Web App Team automation moved this from In Review to In Test Jul 10, 2019
@jryans jryans moved this from In Test to Done in Web App Team Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-Soft-Logout https://github.com/element-hq/element-web/issues/10224 P1 T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support SSO for rehydrating a soft-logged-out session. matrix-org/matrix-react-sdk
2 participants
@jryans @turt2live