Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up cross signing in key backup flow #11212

Closed
11 tasks done
dbkr opened this issue Oct 24, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3640
Closed
11 tasks done

Set up cross signing in key backup flow #11212

dbkr opened this issue Oct 24, 2019 · 1 comment · Fixed by matrix-org/matrix-react-sdk#3640
Assignees
@jryans
Labels
A-E2EE-Cross-Signing

Comments

@dbkr
Copy link
Member

dbkr commented Oct 24, 2019 •
edited by jryans

After #11209

Set up cross signing in the background when setting up a key backup:

  • Add a cross-signing labs flag (@jryans: done separately)
  • When we set up a new key backup, if the labs flag is turned on:
    • Make the 3 keypairs and save them to SSSS along with the key backup key
    • Do the initial set of signatures between the above keypairs & upload to server
  • No UI changes apart from the labs flag

Tasks:

  • Add a cross-signing labs flag
  • Work out React and JS SDK APIs for cross-signing key creation
  • Create cross-signing keys
  • Create SSSS default key, signed with cross-signing master key
  • Store cross-signing keys in SSSS
  • Get cross-signing keys from SSSS on a new device
  • Prompt for secret storage passphrase
  • Sort out device signing upload success even when unauthed
  • Re-sign secret storage key when cross-signing key changes
  • Check why regular keys upload with 200 then embedded 400 (filed Handle errors when uploading key signatures #11574)
  • Add tests
This was referenced Oct 24, 2019
Closed
Open
@dbkr dbkr added this to Up Next in Web App Team Nov 8, 2019
@dbkr dbkr moved this from Up Next to In Progress in Web App Team Nov 8, 2019
@dbkr dbkr self-assigned this Nov 8, 2019
@dbkr dbkr moved this from In Progress to Up Next in Web App Team Nov 12, 2019
@jryans jryans assigned jryans and unassigned dbkr Nov 18, 2019
@jryans jryans moved this from Up Next to In Progress in Web App Team Nov 18, 2019
This was referenced Nov 18, 2019
Closed
Merged
jryans added a commit to matrix-org/matrix-js-sdk that referenced this issue Nov 20, 2019
@jryans
Add first pass at bootstrapping Secure Secret Storage
feef1a3 
This adds a first chunk of bootstrapping Secure Secret Storage by creating
cross-signing keys and supporting interactive auth to upload them.

Part of element-hq/element-web#11212
@jryans jryans mentioned this issue Nov 20, 2019
Merged
jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Nov 20, 2019
@jryans
Add hidden button for bootstrapping SSSS
e6dea37 
This adds an testing button to the key backup panel which bootstraps the Secure
Secret Storage system (and also cross-signing keys).

Fixes element-hq/element-web#11212
@jryans jryans mentioned this issue Nov 20, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Nov 20, 2019
@jryans jryans moved this from In Review to In Progress in Web App Team Nov 25, 2019
@jryans
Copy link
Collaborator

jryans commented Nov 25, 2019

From chatting with @dbkr today, he'll be taking over remaining work here.

@jryans jryans assigned dbkr and jryans and unassigned jryans and dbkr Nov 25, 2019
@jryans jryans moved this from In Progress to In Review in Web App Team Nov 27, 2019
@jryans jryans mentioned this issue Nov 29, 2019
Closed
Web App Team automation moved this from In Review to In Test Dec 11, 2019
@jryans jryans added the phase:1 label Feb 10, 2020
@nadonomy nadonomy mentioned this issue Feb 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-E2EE-Cross-Signing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add testing flow to bootstrap secret storage matrix-org/matrix-react-sdk
3 participants
@jryans @dbkr @lampholder