Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom server options help still mentions identity servers #11236

Closed
turt2live opened this issue Oct 26, 2019 · 1 comment · Fixed by #11248
Closed

Custom server options help still mentions identity servers #11236

turt2live opened this issue Oct 26, 2019 · 1 comment · Fixed by #11248
Assignees
@jryans
Labels
A-Identity-Server Privacy T-Defect

Comments

@turt2live
Copy link
Member

No description provided.

@jryans jryans self-assigned this Oct 28, 2019
@jryans jryans added this to In Progress in Web App Team via automation Oct 28, 2019
@jryans
Copy link
Collaborator

jryans commented Oct 28, 2019

Maybe it's good enough to just remove the text about identity servers here entirely? The identity server field can still appear, but that's only for backwards compat with an older homeserver.

jryans added a commit to matrix-org/matrix-react-sdk that referenced this issue Oct 28, 2019
@jryans
Remove unneeded help about identity servers
e3a5550 
The custom server path no longer shows an identity server field (for modern
homeservers), so it's confusing to have the help dialog reference it.

Part of element-hq/element-web#11236
@jryans jryans mentioned this issue Oct 28, 2019
Merged
jryans added a commit that referenced this issue Oct 28, 2019
@jryans
Remove unneeded help about identity servers
716c5c8 
The custom server path no longer shows an identity server field (for modern
homeservers), so it's confusing to have the help dialog reference it.

Fixes #11236
@jryans jryans mentioned this issue Oct 28, 2019
Merged
@jryans jryans moved this from In Progress to In Review in Web App Team Oct 28, 2019
Web App Team automation moved this from In Review to In Test Oct 28, 2019
@turt2live turt2live moved this from In Test to In RC in Web App Team Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Identity-Server Privacy T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unneeded help about identity servers element-hq/element-web
2 participants
@jryans @turt2live