Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key backup seems to contain 0 room keys #13054

Open
jryans opened this issue Apr 7, 2020 · 4 comments
Open

Key backup seems to contain 0 room keys #13054

jryans opened this issue Apr 7, 2020 · 4 comments

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 7, 2020

When @BillCarsonFr was testing a new account between web <-> web or web <-> RiotX, we've observed that the new device doesn't find any message keys in the key backup e.g. the backup is empty:

  • Create a new account with one device on web
  • Create an encrypted room with some messages
  • Add a new device (either web or RiotX)
  • New device correctly receives key backup key via 4S secret sharing
  • However, when the new device tries to restore for backup it doesn't contain any room keys

Questions:

  • Is it just that there is some delay before web will add message keys to the backup...?
  • Is it related to the malformed backup key (backup key stored in the wrong format #12970)? I would expect to see errors though if that were the issue...
@ara4n
Copy link
Member

ara4n commented Apr 7, 2020

I think this is the same as the "online backup didn't seem to be working" at #12966

@dbkr dbkr added this to In Progress in Web App Team Apr 9, 2020
@dbkr dbkr self-assigned this Apr 9, 2020
@dbkr
Copy link
Member

dbkr commented Apr 9, 2020

Hmm - I can't repro this. We delay for up to 10s before backing up keys so if we were very fast it's possible you could have managed to log in before the key was backup up.

@dbkr dbkr removed their assignment Apr 9, 2020
@jryans
Copy link
Collaborator Author

jryans commented Apr 14, 2020

Since we can't reproduce, let's move this after release and retest.

@stevepdp
Copy link

I was able to reproduce this using the given steps.

Both clients: Firefox 95.0 (64-bit) snap on Ubuntu 21.10.

See:
Screenshot from 2021-12-16 17-29-11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Web App Team
In Progress
Development

No branches or pull requests

5 participants