Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable seshat by default #13262

Closed
dbkr opened this issue Apr 18, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4467
Closed

Enable seshat by default #13262

dbkr opened this issue Apr 18, 2020 · 1 comment · Fixed by matrix-org/matrix-react-sdk#4467
Assignees
@turt2live
Labels
A-E2EE-Cross-Signing A-Indexing Indexing messages via Seshat

Comments

@dbkr
Copy link
Member

dbkr commented Apr 18, 2020

It's on in the release config.json but we should also enable it by default.
@aaronraimist aaronraimist added the A-Indexing Indexing messages via Seshat label Apr 18, 2020
@jryans
Copy link
Collaborator

jryans commented Apr 22, 2020

For this one, I believe we can safely enable by removing the flag. The feature itself won't active without the native components, which only exist in the 1.6 series (for official builds).

@turt2live turt2live self-assigned this Apr 22, 2020
@turt2live turt2live added this to In Progress in Web App Team via automation Apr 22, 2020
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2020
@turt2live
Take encrypted message search out of labs
fdcdd25 
Fixes element-hq/element-web#13262

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* element-hq/element-web#12896
* https://github.com/vector-im/riot-web/issues/12385
* element-hq/element-web#11831
* element-hq/element-web#11155

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
@turt2live turt2live mentioned this issue Apr 22, 2020
Merged
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Apr 22, 2020
@turt2live
Take encrypted message search out of labs
475cea8 
Fixes element-hq/element-web#13262

This is part of the cross-signing shipping master plan. Known issues relating to this feature are:
* element-hq/element-web#12896
* https://github.com/vector-im/riot-web/issues/12385
* element-hq/element-web#11831
* element-hq/element-web#11155

In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default).
@turt2live turt2live moved this from In Progress to In Review in Web App Team Apr 22, 2020
Web App Team automation moved this from In Review to In Test Apr 23, 2020
@jryans jryans moved this from In Test to In RC in Web App Team Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
A-E2EE-Cross-Signing A-Indexing Indexing messages via Seshat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Take encrypted message search out of labs matrix-org/matrix-react-sdk
4 participants
@jryans @dbkr @turt2live @aaronraimist