Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate PUT /account_data/... requests during cross-sign resetting #13340

Open
bwindels opened this issue Apr 23, 2020 · 1 comment
Open

Duplicate PUT /account_data/... requests during cross-sign resetting #13340

bwindels opened this issue Apr 23, 2020 · 1 comment

Comments

@bwindels
Copy link
Contributor

bwindels commented Apr 23, 2020

Account data keys being set during the reset:

m.secret_storage.key.DsWOEDhEfdmIUuvgGyyc0Qp6g7zFmkoi
m.secret_storage.default_key
m.megolm_backup.v1
m.secret_storage.key.DsWOEDhEfdmIUuvgGyyc0Qp6g7zFmkoi
m.cross_signing.master
m.cross_signing.self_signing
m.cross_signing.user_signing
m.megolm_backup.v1

m.secret_storage.key.<keyId> gets fired twice with an identical request body. m.megolm_backup.v1 also gets sets twice, and bizarrely the body is different between both requests.

I can imagine this also happening during the initial bootstrap of an account after registration, which could be another ~20s delay on an overloaded matrix.org HS.

@bwindels bwindels changed the title we're firing two identical PUT /account_data/m.secret_storage.key.<keyId> requests during cross-sign resetting we're firing identical PUT /account_data/... requests during cross-sign resetting Apr 23, 2020
@bwindels bwindels changed the title we're firing identical PUT /account_data/... requests during cross-sign resetting Identical PUT /account_data/... requests during cross-sign resetting Apr 23, 2020
@bwindels bwindels changed the title Identical PUT /account_data/... requests during cross-sign resetting Duplicate PUT /account_data/... requests during cross-sign resetting Apr 23, 2020
@jryans
Copy link
Collaborator

jryans commented Apr 23, 2020

Agreed this is not ideal, but it could be a bit tricky to untangle safely, so let's look post-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants