Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylise macOS consistently #13459

Closed
nadonomy opened this issue Apr 30, 2020 · 1 comment · Fixed by #13460
Closed

Stylise macOS consistently #13459

nadonomy opened this issue Apr 30, 2020 · 1 comment · Fixed by #13460
Assignees
@jryans
Labels
A-Session-Mgmt Session / device names, management UI, etc. P2

Comments

@nadonomy
Copy link
Contributor

We currently stylise macOS as Mac OS in device names, which we should update. It'd be worth searching our repo/translation strings/etc to ensure we use macOS everywhere.
@jryans
Copy link
Collaborator

jryans commented Apr 30, 2020 •
edited
Loading

I recall looking at this briefly... It's actually more interesting than it sounds, as we don't have either string in our code directly. Instead, we take the browser's user agent (e.g. Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:77.0) Gecko/20100101 Firefox/77.0) and parse bits out of it, which is where the "Mac OS" is coming from.

I agree it should be updated though, it has bothered me in the past as well. I suppose we could replace "Mac OS" -> "macOS" when we find it in the parsed UA value.

@jryans jryans added the A-Session-Mgmt Session / device names, management UI, etc. label Apr 30, 2020
@jryans jryans self-assigned this Apr 30, 2020
@jryans jryans added this to In Progress in Web App Team via automation Apr 30, 2020
jryans added a commit that referenced this issue Apr 30, 2020
@jryans
Tweak default device name on macOS
dec5ea1 
This tweak's the OS name in the default device name for macOS devices to match
Apple's current branding.

Fixes #13459
@jryans jryans mentioned this issue Apr 30, 2020
Merged
Web App Team automation moved this from In Progress to In Test Apr 30, 2020
@jryans jryans removed the Z-UI/UX label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Session-Mgmt Session / device names, management UI, etc. P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tweak default device name on macOS element-hq/element-web
2 participants
@jryans @nadonomy