Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immediately after joining a room via /join, tab-complete doesn't work at all #3700

Closed
ara4n opened this issue Apr 22, 2017 · 4 comments
Closed

immediately after joining a room via /join, tab-complete doesn't work at all #3700

ara4n opened this issue Apr 22, 2017 · 4 comments
Labels
A-Slash-Commands P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Apr 22, 2017

can't complete names or commands - everything just blinks red
@lampholder lampholder added T-Defect S-Minor Impairs non-critical functionality or suitable workarounds exist P2 type:rte S-Major Severely degrades major functionality or product features, with no satisfactory workaround and removed S-Minor Impairs non-critical functionality or suitable workarounds exist labels Apr 24, 2017
@ara4n
Copy link
Member Author

ara4n commented May 8, 2017 •
edited

this is really annoying and feels as flakey as !@^$

@ara4n ara4n added P1 and removed P2 labels May 8, 2017
@ara4n
Copy link
Member Author

ara4n commented May 8, 2017

it fixes if you switch away from the room and back again.

@t3chguy
Copy link
Member

t3chguy commented May 8, 2017 •
edited

new composer seems to have the autocomplete data of the last room in some cases, in some simply none

Only seems to happen when joining new rooms
also found that after a join new Composer doesn't have focus, but old does

@lukebarnard1
Copy link
Contributor

This is because RoomView calls setUserListFromRoom once on component mount. It should be calling it when we receive the onRoom down the sync stream after joining.

lukebarnard1 pushed a commit to matrix-org/matrix-react-sdk that referenced this issue Jun 23, 2017
Update tab-complete state onRoom received after joining
ddb84f0 
As opposed to doing it when the component mounts.

Fixes element-hq/element-web#3700 (hopefully)
@lukebarnard1 lukebarnard1 mentioned this issue Jun 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Slash-Commands P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jryans @ara4n @lampholder @t3chguy @lukebarnard1