Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickname auto-completion should have priority rules #4267

Closed
devnoname120 opened this issue Jun 10, 2017 · 9 comments
Closed

Nickname auto-completion should have priority rules #4267

devnoname120 opened this issue Jun 10, 2017 · 9 comments

Comments

@devnoname120
Copy link

devnoname120 commented Jun 10, 2017

Description

Nickname auto-completion indiscriminately puts the nicknames of people who are not active on the channel with people who are active, which makes it less useful in my opinion.

There should be priority rules, for instance:

  • Matches the whole nickname
  • Matches the start of the nickname
  • Matches anywhere in the nickname
  • People who last talked
  • People who last connected

Steps to reproduce

  • Go into #henkaku
  • Type xyz and then press <tab>.
  • It's auto-completed to xyzz even though this one never speaks here and I want it to auto-complete to xyz.

Log: No.

Version information

  • Platform: desktop
  • OS: Arch Linux
  • Version: 0.9.10
@dbkr
Copy link
Member

dbkr commented Jun 14, 2017

Is this with the rich text editor or the normal one?

@dbkr dbkr added the ambiguous label Jun 14, 2017
@lampholder
Copy link
Member

@dbkr does the RTE already have some sort of prioritisation feature?

@devnoname120
Copy link
Author

@dbkr This was with the normal one. I didn't test the new editor to see whether it has the same issue or not.

I can't reproduce my example right now (even with the basic editor). I'm not sure if the issue is fixed or not.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 4, 2017

The new editor puts people who have spoken recently first, even if they don't really match the query used to tab-complete. I'll work on this today.

@lheckemann
Copy link

lheckemann commented Aug 20, 2017

The new editor puts people who have spoken recently first

I can't see this behaviour, for me typing gc when "gchristensen (IRC)" last sent a message still suggests "grahamc" first, with the new editor enabled.

@t3chguy
Copy link
Member

t3chguy commented Aug 20, 2017

@lheckemann:

with the new editor enabled

this implies you are using riot.im/app (or an eq thereof) (as newer versions move to using this composer and this composer only)
the RTE has had MANY changes in the current release candidate, or on riot.im/staging if you'd like to have a play

@lheckemann
Copy link

That is indeed much better, thanks for the pointer!

@t3chguy
Copy link
Member

t3chguy commented Aug 20, 2017

no problem!

@lampholder
Copy link
Member

Looks like this can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants