Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering rooms in the left sidebar does not display rooms from collapsed categories #4364

Closed
aperezdc opened this issue Jun 20, 2017 · 4 comments
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement

Comments

@aperezdc
Copy link

Description

When filtering rooms using the input box in the left sidebar, matches from collapsed room categories are not shown.

Steps to reproduce

  • Collapse a room category in the left sidebar.
  • Enter a search string in the room filter input box for which results from the collapsed category would be shown.

Searching for rooms probably should show also the matches from collapsed categories without having to manually un-collapse them.

riot-room-filter-collapsed

Version information

  • Platform: Both web and Electron application.

For the web app:

  • Browser: Any.
  • OS: All.
  • URL: riot.im/develop + riot.im/app

For the desktop app:

  • OS: All.
  • Version: 0.9.10
@lampholder
Copy link
Member

This does seem unintuitive.

The opposite behaviour would be to show all matches in all categories (probably including 'Historical'). It might be best to mock this up and see whether it feels 'right', though my instinct is that it would feel better than the current behaviour.

Even thinking to the future when users might have lots of custom categories, I can't see a particularly compelling case for not always just showing all matching rooms.

@lampholder lampholder added easy S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Jun 20, 2017
@turt2live
Copy link
Member

fwiw, searching with lots of custom categories is kinda... unhelpful:
image

@aperezdc
Copy link
Author

About @turt2live's issue: Probably what I would do is hiding the tiles for titles of the categories which do not contain any room matched by the filter string.

@turt2live
Copy link
Member

This got fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants