Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unread tracker is reset before image are loaded #4789

Open
erdnaxeli opened this issue Aug 14, 2017 · 4 comments
Open

Unread tracker is reset before image are loaded #4789

erdnaxeli opened this issue Aug 14, 2017 · 4 comments
Labels
A-Read-Marker Green line showing how far _you_ have read O-Occasional Affects or can be seen by some users regularly or most users rarely P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@erdnaxeli
Copy link

Description

When you open a room with images in the last messages the unread tracker position and behavior is computed before image are loaded.

Steps to reproduce

See the attached screen capture t.zip. We see the unread tracker, then images are loaded and:

  1. I'm still at the end of the messages
  2. The unread tracker is lost
  3. The "go to unread message" is not also not here.

It should either load images and put them beside my scroll position, or keep the unread tracker.

Version information

  • Platform: web (in-browser)?

  • Browser: Firefox 54.0

  • OS: Ubuntu
    URL: private riot, version 0.11.4

@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users S-Minor Impairs non-critical functionality or suitable workarounds exist P2 ui/ux labels Aug 15, 2017
@lampholder
Copy link
Member

In the video, at 00:07 we see the horizontal green line read marker and the end of the timeline - then all the images are loaded in causing problems.

@lukebarnard1 suggested this problem could be fixed by having correctly-sized placeholders in place of the images before the images have loaded - he suggested that we might already have something similar in place for E2E encrypted rooms that could be retrofitted on to this.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Aug 15, 2017

It's worth noting that in the video the timeline is scrolled down to the bottom, so when the images resize, the timeline pins itself to the most recent message instead of a third of the way down the screen, which is the normal behaviour.

@erdnaxeli
Copy link
Author

It's the normal behaviour, but if the images where already resized the unread tracked would have been outside of the current view and not removed.

@lukebarnard1
Copy link
Contributor

@erdnaxeli yep, I'd put money on that.

@jryans jryans removed the Z-UI/UX label Mar 9, 2021
@afranke afranke added the A-Read-Marker Green line showing how far _you_ have read label Aug 25, 2021
@weeman1337 weeman1337 added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed S-Tolerable Low/no impact on users labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read O-Occasional Affects or can be seen by some users regularly or most users rarely P2 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

6 participants