Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group invites should look and behave like room invites #5226

Closed
turt2live opened this issue Oct 11, 2017 · 3 comments
Closed

Group invites should look and behave like room invites #5226

turt2live opened this issue Oct 11, 2017 · 3 comments
Labels
A-Spaces Spaces, groups, communities S-Tolerable Low/no impact on users T-Defect X-Release-Blocker

Comments

@turt2live
Copy link
Member

Description

Group invite selected:
image

Compared to a normal invite:
image

I feel it should be the same.

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 61
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder lampholder added T-Defect S-Tolerable Low/no impact on users A-Spaces Spaces, groups, communities ui/ux labels Oct 12, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 2, 2017 •
edited by ara4n
Loading

They look totally different. Group invites should look more-or-less like room invites, for better or for worse.

  • Sub-list header should read "Group Invites", the group invites occupying their own list
  • The ( ! ) should be red and should have a tail in the header and the tile itself
  • The text should read "Invite from ... "
  • Clicking on the group invite should put it in a selected state, so that the highlight is correct. This is slightly tricky because a group invite isn't a room.

@lukebarnard1 lukebarnard1 changed the title Clicking a group invite does not mark the tile as highlighted on the LHS Group invites should look and behave like room invites Nov 2, 2017
lukebarnard1 pushed a commit that referenced this issue Nov 3, 2017
Fix group invites such that they look similar to room invites
c60ff5d 
 - Remove CSS for GroupInviteTile - the component should be using RoomTile CSS
 - Added extra tiles to roomCount of RoomSubList header

Part of fixing #5226
This was referenced Nov 3, 2017
Merged
Merged
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 3, 2017 •
edited
Loading

Now they look like:

2017-11-03-122151_249x202_scrot

Fixing "Invite from" is slightly trickier because:

  1. "Invite from" is generated in the js-sdk when calculating the room name ("Invite from ..." is generated in the js-sdk #5502)
  2. We only get the matrix ID of the group inviter (Invites to groups leak the inviter's mxid rather than using displayname #5357)

@ara4n
Copy link
Member

ara4n commented Nov 6, 2017

matrix-js-sdk@4382d69 fixes the remaining item here. The fact it doesn't tell you who invites you is not a huge problem, and we don't even do that for rooms! (if they have an m.room.name)

@ara4n ara4n closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities S-Tolerable Low/no impact on users T-Defect X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@turt2live @ara4n @lampholder @lukebarnard1