Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Riot-web app block suspend #6814

Closed
MurzNN opened this issue May 29, 2018 · 4 comments · Fixed by #11264
Closed

Riot-web app block suspend #6814

MurzNN opened this issue May 29, 2018 · 4 comments · Fixed by #11264
Labels
A-Electron P1 T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@MurzNN
Copy link
Contributor

MurzNN commented May 29, 2018 •
edited
Loading

Riot-web electron app block suspend mode in Mac OS immediately after start app (without starting using camera, mic, making any calls). Is there any way to fix this?

In Mac OS system monitor shows "yes" in column "Preventing sleep" of Riot app.
@lampholder
Copy link
Member

I don't use electron on my mac - what is the user experience of this? Can you not sleep your mac once you've started riot.im electron?

@lampholder lampholder added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter A-Electron labels May 30, 2018
@t3chguy
Copy link
Member

t3chguy commented May 30, 2018

It prevents automatic sleeping when the app dispatches info about a voip call, so related probably to the erratic ringing from past calls on launch

@MurzNN
Copy link
Contributor Author

MurzNN commented May 31, 2018

Seems sleep is blocked if after ending the call, sometimes rooms after call finished - stay with unread messages like:

  • ... placed a voice call.
  • ... answered the call.
  • ... ended the call.

@MurzNN
Copy link
Contributor Author

MurzNN commented May 31, 2018

Here is screenshot with fake unread notifications in Mac OS after ending call: http://i.imgur.com/bThGmA3.png

@t3chguy t3chguy mentioned this issue Sep 5, 2018
Closed
@t3chguy t3chguy changed the title Riot-web app block suspend on MacOS Riot-web app block suspend Apr 10, 2019
@t3chguy t3chguy mentioned this issue Apr 10, 2019
Closed
@lampholder lampholder added the P1 label Apr 30, 2019
dbkr added a commit that referenced this issue Oct 30, 2019
@dbkr
Fix bug preventing display from sleeping after a call
cc840df 
Calls often transition from connected to connected after transitioning
into the connected state (when the ICE layer connects) so we ended up
creating two wake locks and then only stopping one of them.

Don't make another wake lock if we already have one.

Hopefully fixes #6814
@dbkr dbkr mentioned this issue Oct 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Electron P1 T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug preventing display from sleeping after a call element-hq/element-web
3 participants
@MurzNN @lampholder @t3chguy