New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pasting text into composer is buggy with Firefox when dom.event.clipboardevents.enabled is disabled #7062
Comments
This one is especially annoying when trying to quote text by pasting it after a ">". |
Actually, only certain copy-pasted text seems to trigger this bug? Didn't trigger on a GH URL... Following is text originally used to trigger bug:
|
were you in RT mode and is the content you pasted in Rich? |
Thanks for sending the gif! The gif shows some odd behaviour - we certainly shouldn't see the placeholder text whilst there's text in the composer. Perhaps I'm misinterpreting, but I can't see the gif representing the problem originally described. Do you try and send the message in the gif? (It's a bit hard to tell where it loops) |
Yep. When the blank message gets sent is when i press enter with pasted text. Other behavior was included in the gif as it seemed related. |
I can't repro either :( @non-Jedi can you still reproduce this? |
I can still reproduce. It seems to be a firefox-specific issue though. |
Just to make sure, I disabled all firefox extensions/add-ins, and I can still consistently reproduce the issue. |
I can reproduce with any rich text input 100% of the time, both with middle mouse button and Ctrl-v. Workaround: Paste the text to a plain text editor such as GitHub's comment editor or Vim, then copy+paste that. The symptoms after pasting:
In short it's as if the text after pasting appears in a layer on top of the actual input field. Using Firefox 61.0.2 on up-to-date Arch Linux. Server info: matrix-react-sdk version: <local> |
Out of interest, has this issue gone away for people on riot.im/develop as of today? |
@turt2live nope. Still getting the same behavior on riot.im/devel with Firefox. |
I can't reproduce this on Windows. Are people with OSX able to reproduce this at all? It's very possible it's a Linux-only problem. |
@turt2live I can't reproduce on macOS (but I can't reproduce on Ubuntu either so maybe I'm doing something wrong). |
I'm using up-to-date Arch Linux, LightDM and Awesome WM. This issue affects any and all formatted text. Anything I paste (unlike @igh2 this includes parts of the single line of unformatted text I've typed into the Riot editor) I first have to drop into a plain text editor or terminal to avoid triggering this issue. This is on riot-web version 0.17.3 |
Qtile. But problem exists if I run Firefox without any de or wm as well. EDIT: To be clear, I'm saying that the problem exists if I do something like the following in a tty before starting X:
|
let me double check that problem isn't isolated to single computer when I get a chance. |
I was able to reproduce this bug in firefox on windows 7 on riot.im/app. |
This is limiting Riot's usefulness for anything other than stream-of-consciousness messaging. These are my results with Firefox 63 on Fedora 29 with GNOME, pasting into a markdown-enabled editor field.
|
im facing the exact same issue. this is a huge usability issue. and is affecting our ability to use it. Is riot using slatejs ? https://github.com/ianstormtaylor/slate |
Hi, I’m experiencing exactly the same problem with riot in Firefox for some months now, making pasting virtually impossible for me. I’m on Arch Linux, MATE desktop, X.org. Added to that, when I paste an URL, riot keeps adding some weird characters to it (%EF%BB%BF), making the links impossible to open by my chat partners. |
I made a video about this. It seems to be indeed Firefox-specific and was present in the old Riot Web UI as well as the new re-design: https://youtu.be/4OeOR6dXAQk Steps to reproduce:
Expected behavior: Text gets deleted. Same happens with plaintext, however there I could reproduce the behavior by cutting and pasting a part of the text into the input itself. I'm on Firefox 65.0 (64-bit) and Ubuntu 16.04 with i3wm running without compositor. |
@sandys Yes Riot is using Slate |
@t3chguy I'm guessing it might be a Slate.js bug then. If I go to https://www.slatejs.org/#/rich-text and repeat my steps to reproduce, I get this error:
Again, this does not happen if I do this in my Chromium instance. Just filed a bug there: ianstormtaylor/slate#2612 |
@lampholder Given that a significant number of people have found their way to this issue after reproducing, could this issue get assigned a priority tag of some sort? |
i guess the reason it's not prioritised is because we've been unable to repro it, so it's hard to tell how many people are affected. but circumstantially it seems to be biting people a bunch, so will P1 it. |
I can also reproduce this issue (and have been experiencing it for the better part of a year, but kept forgetting to file an issue about it). Given the comment in ianstormtaylor/slate#2612 it seems to be a Linux+Firefox specific issue. Here is a GIF of the issue (I'm on openSUSE Tumbleweed with Firefox 65.0.1). EDIT: Yup, I have |
This issue is caused by disabling The workaround is to simply flip the value of |
@dms-cat Another option is to use https://addons.mozilla.org/en-US/firefox/addon/don-t-fuck-with-paste/ which should let you choose to only block those events on certain sites rather than disabling a fairly important feature across all sites. (yes I am the maintainer of that add-on on Firefox, but I'm also part of the matrix community) |
Thanks for tracking down the root problem @dms-cat (this has now become my favorite example of correlation \neq causation). Linux users are more likely to use password managers, and people using password managers are more likely to have To the Riot devs, given the above, is this a won't-fix or not actually considered a bug or something? |
Is this still an issue for you in the new composer? |
For me it appears not to be an issue anymore, and I have This is on FF 74.0 (64-bit) under Ubuntu 18.04.4 |
Description
Pasting into the editor if not at beginning of a message makes it look like the message was composed correctly, but upon sending, the pasted text is not sent.
Steps to reproduce
dom.event.clipboardevents.enabled
inabout:config
Version information
For the web app:
The text was updated successfully, but these errors were encountered: