Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign: polish room list #7567

Closed
8 tasks done
bwindels opened this issue Oct 25, 2018 · 8 comments
Closed
8 tasks done

Redesign: polish room list #7567

bwindels opened this issue Oct 25, 2018 · 8 comments

Comments

@bwindels
Copy link
Contributor

bwindels commented Oct 25, 2018

  • use SVG icon instead of "+" character for add room button
  • fix chevron clipping
  • polish margins
  • show correct context menu icon on room tile hover
  • style context menu button
  • bring back "filter rooms" field
  • polish/align badge with design
  • add border around badge same as background color
  • if not done sooner, show room section header badge also when section is expanded (not collapsed).

Questions:

  • Where do the mute settings go? Design for context menu does not have them.
@bwindels
Copy link
Contributor Author

@nadonomy just about knowing what to do with the mute settings.

@lampholder lampholder added this to Todo (Unordered) in Redesign Backlog Oct 26, 2018
@lampholder lampholder moved this from All redesign tasks (Unordered) to Prioritized next list in Redesign Backlog Oct 26, 2018
@lampholder lampholder added this to the RW016 milestone Oct 26, 2018
@bwindels bwindels added this to In Progress in Web App Team Nov 2, 2018
@bwindels
Copy link
Contributor Author

bwindels commented Nov 2, 2018

Nad will have a look at making the margins a bit denser by the end of next monday, I'll implement the ones in the current design for now.

@bwindels
Copy link
Contributor Author

bwindels commented Nov 6, 2018

Put the remaining work for the context menu in #7666, so we can close this.

@bwindels bwindels closed this as completed Nov 6, 2018
@bwindels bwindels moved this from In Review to In Test in Web App Team Nov 7, 2018
@bwindels bwindels moved this from In Test to Done in Web App Team Nov 15, 2018
@aaronraimist
Copy link
Collaborator

Russian text appears bold (as if unread) on /experimental compared to English text
@bwindels do you want me to file a new issue?

screen shot 2018-12-04 at 7 15 50 pm
screen shot 2018-12-04 at 7 16 13 pm

@bwindels
Copy link
Contributor Author

bwindels commented Dec 6, 2018

Interesting, thanks for reporting (here is fine). @nadonomy I guess this might tie into our font choice?

@bwindels
Copy link
Contributor Author

bwindels commented Dec 6, 2018

Hmm, maybe it's just a matter of lowering the font-weight.

@bwindels
Copy link
Contributor Author

bwindels commented Dec 6, 2018

Yeah, changing the font-weight from 600 to 599 seems to only affect the non-latin typography in Nunito.
fw-600
fw-599

@nadonomy
Copy link
Member

nadonomy commented Dec 6, 2018

This is super interesting. Definitely some inconsistencies across different character sets in Nunito:

charactersets

Need to explore and ponder a bit more on how we can solve this better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Redesign Backlog
Prioritised Next (Ordered)
Development

No branches or pull requests

5 participants