Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Encrypt aggregation key in E2E rooms #9672

Closed
jryans opened this issue May 10, 2019 · 2 comments
Closed

Reactions: Encrypt aggregation key in E2E rooms #9672

jryans opened this issue May 10, 2019 · 2 comments

Comments

@jryans
Copy link
Collaborator

jryans commented May 10, 2019

The aggregation key / reaction value should be encrypted using the message key of the original event being reacted to.

@jryans jryans self-assigned this May 13, 2019
@jryans jryans added this to In Progress in Web App Team via automation May 13, 2019
@jryans jryans added phase:2 and removed phase:1 labels May 16, 2019
@jryans jryans removed their assignment May 16, 2019
@jryans jryans removed this from In Progress in Web App Team May 16, 2019
@jryans jryans added phase:3 and removed phase:2 labels Jun 12, 2019
@jryans
Copy link
Collaborator Author

jryans commented Jun 12, 2019

This is no longer required for shipping reactions. We plan to add metadata to the encrypted aggregation keys so that it's clear to the client when they do need decryption.

@turt2live
Copy link
Member

This is a spec issue, for which I believe an issue already exists (or at least a comment on the STILL unmerged MSC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants