Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require descriptions in mxSendRageshake and remove infinite loop in issue templates #10321

Merged
merged 2 commits into from Jul 12, 2019
Merged

Require descriptions in mxSendRageshake and remove infinite loop in issue templates #10321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79b519b
Require a rageshake description in mxSendRageshake
turt2live Jul 11, 2019
604e4bb
Improve wording in debug log sending in issue templates
turt2live Jul 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Expand Up @@ -31,9 +31,10 @@ Describe here the problem that you are experiencing, or the feature you are requ

Describe how what happens differs from what you expected.

Log: sent/not sent? <!-- You can send us the app's logs via the 'Report bug'
link on the 'Settings' page. Very important for hard-to-reproduce bugs. Please
file a bug here too! -->
<!-- Please send us logs for your bug report. They're very important for bugs
which are hard to reproduce. To do this, create this issue then go to your
account settings and click 'Submit Debug Logs' from the Help & About tab -->
Logs being sent: yes/no

<!-- Include screenshots if possible: you can drag and drop images below. -->

Expand Down
7 changes: 4 additions & 3 deletions .github/ISSUE_TEMPLATE/user-interface-or-usability-bug-report.md
View file
Open in desktop
Expand Up @@ -33,9 +33,10 @@ Describe here the problem that you are experiencing, or the feature you are requ

Describe how what happens differs from what you expected.

Log: sent/not sent? <!-- You can send us the app's logs via the 'Report bug'
link on the 'Settings' page. Very important for hard-to-reproduce bugs. Please
file a bug here too! -->
<!-- Please send us logs for your bug report. They're very important for bugs
which are hard to reproduce. To do this, create this issue then go to your
account settings and click 'Submit Debug Logs' from the Help & About tab -->
Logs being sent: yes/no

<!-- Include screenshots if possible: you can drag and drop images below. -->

Expand Down
4 changes: 4 additions & 0 deletions src/vector/rageshakesetup.js
View file
Open in desktop
Expand Up @@ -50,6 +50,10 @@ initRageshake();

global.mxSendRageshake = function(text, withLogs) {
if (withLogs === undefined) withLogs = true;
if (!text || !text.trim()) {
console.error("Cannot send a rageshake without a message - please tell us what went wrong");
return;
}
require(['matrix-react-sdk/lib/rageshake/submit-rageshake'], (s) => {
s(SdkConfig.get().bug_report_endpoint_url, {
userText: text,
Expand Down