Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load config.json before loading language so default can apply #10551

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Load config.json before loading language so default can apply #10551

merged 1 commit into from
Aug 14, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Aug 14, 2019

Fixes #10548

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

@t3chguy t3chguy requested a review from a team August 14, 2019 11:30
dbkr
dbkr approved these changes Aug 14, 2019
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks reasonable - trying to think of anything we do that involves displaying i18ned strings before this point, but I don't think there would be.

@dbkr dbkr merged commit 3b908f4 into develop Aug 14, 2019
@t3chguy
Copy link
Member Author

t3chguy commented Aug 14, 2019

Err, I left my debug lines in there. Whooops

@turt2live
Copy link
Member

fixed in 9ed647d

Thanks for noticing @t3chguy

@t3chguy t3chguy deleted the t3chguy/i18n_config_default branch May 12, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default language setting doesn't work
3 participants
@t3chguy @turt2live @dbkr