Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log query parameters as they may contain secrets #10929

Merged
merged 1 commit into from Sep 22, 2019

Conversation

@t3chguy
Copy link
Collaborator

t3chguy commented Sep 21, 2019

Fixes matrix-org/internal-config#644

I scanned the project for any other logs which record the query parameters and did not find any others.

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from vector-im/riot-web Sep 21, 2019
@jryans
jryans approved these changes Sep 21, 2019
Copy link
Member

jryans left a comment

Thanks, looks reasonable to me!

@t3chguy t3chguy merged commit 0c187b4 into develop Sep 22, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #954 passed (3 minutes, 55 seconds)
Details
buildkite/riot-web/eslint-lint Passed (52 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes)
Details
buildkite/riot-web/karma-tests Passed (2 minutes, 30 seconds)
Details
buildkite/riot-web/pipeline Passed (9 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.