Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform favicon updates twice in Chrome #11375

Merged
merged 3 commits into from Nov 12, 2019
Merged

Perform favicon updates twice in Chrome #11375

merged 3 commits into from Nov 12, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Nov 12, 2019 •
edited

See diff for why this arcane magic is needed.

Fixes #11347

Upstream bug: ejci/favico.js#152

@turt2live
Perform favicon updates twice in Chrome
ec9a38c 
See diff for why this arcane magic is needed.

Fixes #11347
@turt2live turt2live requested a review from a team November 12, 2019 22:03
t3chguy
t3chguy approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sure is nasty. Assuming it works LGTM other than styling

src/vector/platform/VectorBasePlatform.js Outdated Show resolved Hide resolved
@turt2live
Copy link
Member Author

It does work, which is the annoying part.

@turt2live turt2live merged commit 2e64231 into develop Nov 12, 2019
@turt2live turt2live deleted the travis/fix-chrome-favicon branch November 12, 2019 22:20
@steef435 steef435 mentioned this pull request Apr 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Favicon icon doesn't change to red anymore
2 participants
@turt2live @t3chguy