Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform favicon updates twice in Chrome #11375

Merged
merged 3 commits into from Nov 12, 2019
Merged

Conversation

@turt2live
Copy link
Member

turt2live commented Nov 12, 2019

See diff for why this arcane magic is needed.

Fixes #11347

Upstream bug: ejci/favico.js#152

See diff for why this arcane magic is needed.

Fixes #11347
@turt2live turt2live requested a review from vector-im/riot-web Nov 12, 2019
Copy link
Collaborator

t3chguy left a comment

That sure is nasty. Assuming it works LGTM other than styling

src/vector/platform/VectorBasePlatform.js Outdated Show resolved Hide resolved
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Nov 12, 2019

It does work, which is the annoying part.

@turt2live turt2live merged commit 2e64231 into develop Nov 12, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1283 passed (5 minutes, 8 seconds)
Details
buildkite/riot-web/eslint-lint Passed (44 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 11 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 42 seconds)
Details
buildkite/riot-web/pipeline Passed (7 seconds)
Details
@turt2live turt2live deleted the travis/fix-chrome-favicon branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.