Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a theme change on startup, not just a tint change #11381

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Nov 13, 2019

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Nov 13, 2019
Useful for trying to load the right assets first. 

See element-hq/element-web#11381
@turt2live turt2live requested a review from a team November 13, 2019 21:04
@turt2live
Copy link
Member Author

it bothers me that the tests pass before the react-sdk branch exists :(

Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 😁

src/vector/index.js Show resolved Hide resolved
@turt2live turt2live merged commit 515db51 into develop Nov 14, 2019
@turt2live turt2live deleted the travis/base-theme branch November 14, 2019 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting theme to custom-<theme name> doesn't actually default users to the custom theme
2 participants