Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger a theme change on startup, not just a tint change #11381

Merged
merged 1 commit into from Nov 14, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Nov 13, 2019

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Nov 13, 2019
Useful for trying to load the right assets first. 

See vector-im/riot-web#11381
@turt2live turt2live requested a review from vector-im/riot-web Nov 13, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Nov 13, 2019

it bothers me that the tests pass before the react-sdk branch exists :(

@jryans
jryans approved these changes Nov 14, 2019
Copy link
Member

jryans left a comment

Thanks! 😁

src/vector/index.js Show resolved Hide resolved
@turt2live turt2live merged commit 515db51 into develop Nov 14, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1290 passed (4 minutes, 54 seconds)
Details
buildkite/riot-web/eslint-lint Passed (56 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 32 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 32 seconds)
Details
buildkite/riot-web/pipeline Passed (4 seconds)
Details
@turt2live turt2live deleted the travis/base-theme branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.