Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give contextual feedback for manual update check instead of banner #13862

Merged
merged 1 commit into from May 30, 2020
Merged

Give contextual feedback for manual update check instead of banner #13862

merged 1 commit into from May 30, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 29, 2020 •
edited

@t3chguy
Give contextual feedback for manual update check instead of banner
1fd74f2 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 29, 2020 17:26
@t3chguy
Copy link
Member Author

t3chguy commented May 29, 2020

Test failured expected until required PR lands

@t3chguy t3chguy requested a review from a team May 29, 2020 17:37
@t3chguy t3chguy mentioned this pull request May 29, 2020
Merged
nadonomy
nadonomy approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@t3chguy t3chguy merged commit e368007 into develop May 30, 2020
@t3chguy t3chguy deleted the t3chguy/toasts6 branch May 30, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manual check for update doesn't dismiss update bar
3 participants
@t3chguy @turt2live @nadonomy