Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow deferring of Update Toast until the next morning #13864

Merged
merged 1 commit into from
May 30, 2020
Merged

Allow deferring of Update Toast until the next morning #13864

merged 1 commit into from
May 30, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 29, 2020

Fixes #11042
Staged atop #13862
Requires matrix-org/matrix-react-sdk#4669

image

Later will defer it until the first of the following:

  • tomorrow morning (8am)
  • the user clicks Check for update in settings
  • an even newer update comes out

@t3chguy
Allow deferring of Update Toast until the next morning
66272fc 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested review from a team May 29, 2020 19:03
turt2live
turt2live requested changes May 29, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like shouldShowUpdate is missing from the diff...

turt2live
turt2live approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind, the branch stacking just happened in the wrong order

nadonomy
nadonomy approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from t3chguy/toasts6 to develop May 30, 2020 11:54
@t3chguy t3chguy merged commit afd0d69 into develop May 30, 2020
@t3chguy t3chguy deleted the t3chguy/toasts6_1 branch May 30, 2020 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turt2live turt2live turt2live approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please remove "new version" notification.
3 participants
@t3chguy @turt2live @nadonomy