Configure eslint package and fix lint issues #14673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorikSchellekens
changed the title
turt2live
approved these changes
Jul 21, 2020
| @@ -29,6 +29,7 @@ export default class VectorEmbeddedPage extends EmbeddedPage { | |||
| translate(s) { | |||
| s = sanitizeHtml(_t(s)); | |||
| // ugly fix for https://github.com/vector-im/riot-web/issues/4243 | |||
| // eslint-disable-next-line max-len | |||
| s = s.replace(/\[matrix\]/, '<a href="https://matrix.org" target="_blank" rel="noreferrer noopener"><img width="79" height="34" alt="[matrix]" style="padding-left: 1px;vertical-align: middle" src="welcome/images/matrix.svg"/></a>'); | |||
There was a problem hiding this comment.
why does this even exist 😭
(not an issue for this PR, just expressing my sadness for such a regex)
There was a problem hiding this comment.
I have no idea
| @@ -23,7 +23,7 @@ import { Capability, WidgetApi } from "matrix-react-sdk/src/widgets/WidgetApi"; | |||
| // Dev note: we use raw JS without many dependencies to reduce bundle size. | |||
| // We do not need all of React to render a Jitsi conference. | |||
|
|
|||
| declare var JitsiMeetExternalAPI: any; | |||
| declare let JitsiMeetExternalAPI: any; | |||
There was a problem hiding this comment.
I'm somewhat sure we used var for a reason, but I guess we'll find out :D
|
merging to try and unbreak develop |
refi64
added a commit
to refi64/riot-web-lc
that referenced
this pull request
Jul 28, 2020
[Full Changelog](element-hq/element-web@v1.7.1...v1.7.2) * Upgrade to React SDK 3.0.0 and JS SDK 8.0.0 * Update from Weblate [\element-hq#14778](element-hq#14778) * Capitalize letters [\element-hq#14566](element-hq#14566) * Configure eslint package and fix lint issues [\element-hq#14673](element-hq#14673) * Riot → Element [\element-hq#14581](element-hq#14581) * Remove labs info for the new room list [\element-hq#14603](element-hq#14603) * Convince Webpack to use development on CI [\element-hq#14593](element-hq#14593) * Move dev dep to the right place [\element-hq#14572](element-hq#14572) * Bump lodash from 4.17.15 to 4.17.19 [\element-hq#14552](element-hq#14552) * Update all mobile links to match marketing site [\element-hq#14541](element-hq#14541)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TS is now linted