Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rejig the PaswordNagBar #4026

Merged
merged 1 commit into from May 25, 2017
Merged

Rejig the PaswordNagBar #4026

merged 1 commit into from May 25, 2017

Conversation

lukebarnard1
Copy link
Contributor

  • Change the nag bar to read "To return to your account in future you need to set a password"
  • Underline "Set a password"
  • Make the whole thing clickable

Rejig the PaswordNagBar
1db3ba6 
 - Change the nag bar to read "To return to your account in future you need to set a password"
 - Underline "Set a password"
 - Make the whole thing clickable
dbkr
dbkr approved these changes May 25, 2017
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, relying on event bubbling is a bit magic but I guess.

@dbkr dbkr assigned lukebarnard1 and unassigned dbkr May 25, 2017
@lukebarnard1
Copy link
Contributor Author

Well, having two onClicks risks two dialogues popping up I think.

@lukebarnard1 lukebarnard1 merged commit b25e6eb into new-guest-access May 25, 2017
@t3chguy t3chguy deleted the luke/new-guest-access-rejig-nagbar branch May 12, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukebarnard1 @dbkr