Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations! #4035

merged 29 commits into from May 26, 2017


Copy link

dbkr commented May 26, 2017

Merged from #3636

dbkr added 29 commits May 23, 2017
Use async/await consistently rather than flipping between that and
callbacks, s/var/let/, indenting
as they don't seem to be necessary
If we're defaulting this it should really be by the component
itself or with the other defaukts in SdkConfig, but we've decided
to leave out support for reading languages from the config file as
it's only useful for a Riot admin to restrict the choice of
languages available to users which is of debateable use.
to use react-sdk wrapper function, rather than using counterpart
We now use stock counterpart, but indirectly via react-sdk so no
need to depend on it directly.
and remove extCounterpart which is unnecessary now we just use a
single counterpart instance
We now get multiple languages from the browser as there may be
a whole preference list
Change array.push guideline to not using _t at class-load time
which was probably the actual problem. Update guidelines to
include punctuation.
As it is in English and not German
It's even less use in a comment
 * Move language files to strings/ subdir to be consistent with
 * Only copy static list of languages (to avoid including
   languages that are only a few percent translated)
 * Make copy-res script work with watch mode
 * Other general cleanups like only write each language file once,
   rather than n times.

This comment has been minimized.

Copy link

ara4n commented May 26, 2017

lgtm other than "ewwwwww" at en_en being a 1:1 lookup, and the dropdown still being a bit ugly in settings (but i can fix that post-merge)

@dbkr dbkr referenced this pull request May 26, 2017
@dbkr dbkr merged commit 5e0457c into develop May 26, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.