Make member device info buttons fluid and stackable with flexbox #4776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buttons with short text stay as they are, buttons with long text don't get overflowed, but just grow and wrap on a new line if needed, still remaining aligned with others (see screenshot in PR comments) Signed-off-by: Andrei Shevchuk <andrei@shevchuk.co>
| @@ -18,6 +18,13 @@ limitations under the License. | |||
| padding: 10px 0px; | |||
| } | |||
|
|
|||
| .mx_MemberDeviceInfo.mx_DeviceVerifyButtons { | |||
| width: 100%; | |||
There was a problem hiding this comment.
I'm not convinced this is necessary
There was a problem hiding this comment.
Yeah, no need in this as div has 100% width by default, I will remove this
lukebarnard1
approved these changes
Aug 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons with short text stay as they are, buttons with long text don't get overflowed, but just grow and wrap on a new line if needed, still remaining aligned with others (helpful for translations that don't have short enough equivalent for button labels)
Screenshot (short English labels, longer Russian labels):
It would be nice to get those into a device context menu eventually, the same as message actions are now under the message context menu.
Same as the #4703 but based on
developbranch as @t3chguy and @lukebarnard1 suggested.Signed-off-by: Andrei Shevchuk andrei@shevchuk.co