Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make member device info buttons fluid and stackable with flexbox #4776

Merged
merged 2 commits into from Aug 10, 2017

Conversation

@shvchk
Copy link
Contributor

shvchk commented Aug 10, 2017

Buttons with short text stay as they are, buttons with long text don't get overflowed, but just grow and wrap on a new line if needed, still remaining aligned with others (helpful for translations that don't have short enough equivalent for button labels)

Screenshot (short English labels, longer Russian labels):
Screenshot

It would be nice to get those into a device context menu eventually, the same as message actions are now under the message context menu.

Same as the #4703 but based on develop branch as @t3chguy and @lukebarnard1 suggested.

Signed-off-by: Andrei Shevchuk andrei@shevchuk.co

Buttons with short text stay as they are, buttons with long text don't get overflowed, but just grow and wrap on a new line if needed, still remaining aligned with others (see screenshot in PR comments)

Signed-off-by: Andrei Shevchuk <andrei@shevchuk.co>
@@ -18,6 +18,13 @@ limitations under the License.
padding: 10px 0px;
}

.mx_MemberDeviceInfo.mx_DeviceVerifyButtons {
width: 100%;

This comment has been minimized.

Copy link
@lukebarnard1

lukebarnard1 Aug 10, 2017

Contributor

I'm not convinced this is necessary

This comment has been minimized.

Copy link
@shvchk

shvchk Aug 10, 2017

Author Contributor

Yeah, no need in this as div has 100% width by default, I will remove this

Copy link
Contributor

lukebarnard1 left a comment

LGTM, thanks @shvchk !

@lukebarnard1 lukebarnard1 merged commit 7529343 into vector-im:develop Aug 10, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.