Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix riot-web Promise.defer warnings (#7409) #7444

Merged
merged 5 commits into from Oct 9, 2018

Conversation

@aaronraimist
Copy link
Contributor

aaronraimist commented Oct 3, 2018

More progress on #7409

@turt2live turt2live requested a review from vector-im/riot-web Oct 3, 2018
src/vector/platform/WebPlatform.js Outdated Show resolved Hide resolved
src/vector/platform/WebPlatform.js Outdated Show resolved Hide resolved
src/vector/index.js Outdated Show resolved Hide resolved
src/vector/getconfig.js Outdated Show resolved Hide resolved
@bwindels

This comment has been minimized.

Copy link
Contributor

bwindels commented Oct 4, 2018

Thanks! Have you done the Sign-Off already?

@dbkr

This comment has been minimized.

Copy link
Member

dbkr commented Oct 4, 2018

(DCO signoff is in the commit messages)

aaronraimist added 4 commits Oct 3, 2018
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist aaronraimist force-pushed the aaronraimist:promise-defer branch from 6fbbb98 to d035efb Oct 5, 2018
I guess that turns on warnings for everything, not just riot-web

Signed-off-by: Aaron Raimist <aaron@raim.ist>
@aaronraimist

This comment has been minimized.

Copy link
Contributor Author

aaronraimist commented Oct 9, 2018

This should be ready to go @bwindels

@turt2live turt2live merged commit 92db2b8 into vector-im:develop Oct 9, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@turt2live

This comment has been minimized.

Copy link
Member

turt2live commented Oct 9, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.