Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update electron builder #8231

Merged
merged 2 commits into from Jan 23, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Jan 23, 2019

This resolves an issue where the auto-updater on Mac with a standard
(ie. non-admin) user account would leave the app in a broken,
unlaunchable state (although it's not obvious what change in
electron-builder fixes this).

Fixes #8215

This resolves an issue where the auto-updater on Mac with a standard
(ie. non-admin) user account would leave the app in a broken,
unlaunchable state (although it's not obvious what change in
electron-builder fixes this).

Fixes #8215
@dbkr dbkr requested a review from vector-im/riot-web Jan 23, 2019
@bwindels

This comment has been minimized.

Copy link
Contributor

bwindels commented Jan 23, 2019

lgtm, I guess you've confirmed in one way or another that this fixes the issue?

@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Jan 23, 2019

Yeah, just tried updating manually and installing on a standard mac user account and it now appears to work.

@dbkr dbkr merged commit f7c2603 into experimental Jan 23, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jryans

This comment has been minimized.

Copy link
Member

jryans commented Jan 23, 2019

I believe the fix for electron-userland/electron-builder#3435 which landed in v20.31.2 is what also fixed our issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.