Update electron builder #8231
Merged
Update electron builder #8231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue where the auto-updater on Mac with a standard (ie. non-admin) user account would leave the app in a broken, unlaunchable state (although it's not obvious what change in electron-builder fixes this). Fixes #8215
bwindels
approved these changes
Jan 23, 2019
|
lgtm, I guess you've confirmed in one way or another that this fixes the issue? |
|
Yeah, just tried updating manually and installing on a standard mac user account and it now appears to work. |
|
I believe the fix for electron-userland/electron-builder#3435 which landed in v20.31.2 is what also fixed our issue here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the auto-updater on Mac with a standard
(ie. non-admin) user account would leave the app in a broken,
unlaunchable state (although it's not obvious what change in
electron-builder fixes this).
Fixes #8215