Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable room directory test because it doesn't work #8318

Merged
merged 1 commit into from Jan 30, 2019

Conversation

@turt2live
Copy link
Member

turt2live commented Jan 30, 2019

See enclosed comments.

See enclosed comments.
@turt2live turt2live requested a review from vector-im/riot-web Jan 30, 2019
@turt2live turt2live added this to In Review in Workflow Jan 30, 2019
@turt2live

This comment has been minimized.

Copy link
Member Author

turt2live commented Jan 30, 2019

(the build should be green on this PR)

@dbkr
dbkr approved these changes Jan 30, 2019
Copy link
Member

dbkr left a comment

Hmm, yeah - we just put our dialogs in a new div we create and append straight to the body, so I'm not surprised it can't find it as a chid of MatrixChat. I'm not wholly surprised it doesn't work with the whole document either actually, as I think its done as a whole separate ReactDom.render(), so a whole separate react document tree.

Easiest answer is probably to have one dialog container within MatrixChat and render it as part of the same document tree.

@dbkr dbkr merged commit 1391706 into experimental Jan 30, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@bwindels bwindels moved this from In Review to In Test in Workflow Jan 30, 2019
@turt2live turt2live deleted the travis/fix-build branch Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.